feat(navigation): gate editor activation capabilities - #400
Closed
dubesinhower wants to merge 16 commits into
Closed
feat(navigation): gate editor activation capabilities#400dubesinhower wants to merge 16 commits into
dubesinhower wants to merge 16 commits into
Conversation
Collaborator
|
Accounting complete in #494. That focused replacement keeps the generally useful portion of this draft—separate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigation MVP slice N5
Adds semantic, exact-context capability gates for document/sheet activation, object reveal/centering, and view fitting. On the bundled KiCad 10 protocol these operations return typed unsupported results and send no raw action.
Why this belongs in the MVP
Clients need an honest answer about activation and viewport behavior. Pretending that selection implies reveal, or routing through unstable action strings without active-context readback, would violate the Navigation MVP's safety contract.
Dependency
Behavior
activate_document,activate_sheet,reveal_object,center_object, orfit_viewas typedunsupported_capabilitywith the observed version when no stable command plus active-context readback exists.GetOpenDocumentsandGetVersionprobes; noRunAction, mouse, keyboard, or coordinate automation is exposed.Intentionally unsupported
Verification
cargo fmt --all -- --checkcargo test -p konnect-core editor_navigation --lib— 15 passedcargo test -p konnect-ipc --test mock_server_test— 47 passed, 1 ignoredcargo test -p konnect-core --lib— 946 passed, 9 ignoredcargo test --workspace --all-targets— passed (live/environment-only tests remained ignored)cargo clippy --workspace --all-targets -- -D warningsxtask fix-doc-counts --check— 21 toolsets, 226 registered, 233 totalgit diff --checkHermetic tests prove typed unsupported capability/version output, exact context probing, stale-object refusal before IPC, schematic
activate_sheetclassification, and the absence of any raw action request.Remaining risks